Dashboard

Remove sql duplication, converge oracle and postgres codebase

Prevent user from selecting source folder as destination folder when moving files. Localize feedback messages (thanks to Markus Moser for the germen translation)

- Refactor ad_get_login_url reduce replicated code and to make semantics clearer

- ad_get_login_url handles now as well cases, where a subsite is mapped to an application package on a subsite

- fix a bug in util_current_location in connection with hostnode map

    • -127
    • +144
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Fix typo in comment

provide default for email_verified_p

- Don't name valdation black and formal argument the same

make sure, the message key in the comment is shown correctly in API browser

- handle fetch via revision_id over perpared statement

- repated formfields: set repeat formfield empty if nothing is returned from form (man thanks to Thomas Renner for the patch)

    • -0
    • +11
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
When the kernel parameter "NsShutdownWithNonZeroExitCode" is set (e.g. in the config file) and NaviServer is used, return with a non-zero exit code after ns_shutdown. This lets e.g. windows system to restart the service automatically (the sample config file for openacs in the naviserver archive is updated as an example)

Use per-thread caching instead of nsv for never-changing variable (use ::acs::database_type instead of nsv ad_database_type; when available)

This improves concurrency and performance for tight loops (e.g. in developer support)

fix for cases in repeat fields, where min != 1

    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
- use shortcut for "select" in db_exec_plsql to bypass anonymous function creation

- use shortcut for "select" in db_exec_plsql to bypass anonymous function creation

- remove misleading SQL statement

Improve HTML

- fixing regexp for message key in group::new

- Introducing lang::util::message_key_regexp to avoid similar confusions in the future

- bump verison number of acs-lang to 5.9.1b4

- bump version number of acs-subsite to 5.9.1b5

remove unneeded xql query

group::party_member_p

- provided a warning, when specified group_id is ignored

- fix dicumentation

- simplify logic

group::get_id_not_cached;

- provide a warning, when subsite overrulese a specified application_group_id

- provide a warning, when multiple groups with the same name exists, but an arbitrary one is returned

- don't ignore specified subsite_id

- remove tests, which are always true

Fixed regression on upgrade script

- fix bug in group::get_id: don't ignore application_group_id in case it is provided

Fix code in cases, were object_type is not provided

- fix broken list nesting of html widget specs

- use links more consistent: add prefix /api-doc/ to urls for "see also" (like in other cases)

addressing #3318 (the actual bug was there for 10+ years)

Fix typo in html attributes definition (this enables proper styling and input checks).

Put formwidget directly into markup, otherwise the templating system complains about missing id for the submit widget.

compare with group_id, not subsite_id

- when ShowMembersListTo is set to "3", show list to members only, when this is not the whole subsite

- improve documentation