• last updated 42 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Skip permission checks outside the connection context (in the sweeper)

Rework permission check

Make chat_id required, as path to the chat.tcl script is now immutable and all the potentially expensive package_id retrieval was only due to defaulting the chat_id. Use cases around already define their chat_id independently

    • -21
    • +5
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
new feature: allow default of form-fields to be honored on new entries

This change allows an userfor instance to create folders with predefined

content renderer, which can be altered by the end user.

support Subresource Integrity (SRI) settings in template::head::add_css (crossorigin and integrity)

add csp rules for bootstrap style files

use URN version of jquery when available

bump verison number to 5.10.0d9

added: template::head::can_resolve_urn

Check permissions: chat_read always and chat_write whenever we post

Add URN-resover for add_body_script

Fix typo

    • -2
    • +2
    /openacs-4/packages/chat/www/index.tcl
whitespace changes

extend regression test to cover webcallable funcitons

add comments to the web callable functions (at least the AJAX ones)

Just log the complaint instead of showing it to the user (script would keep going anyway, as it is not aborted). Needed for automated tests

Add doc

automated tests: fix broken argument in test case

- return results as dict

- make array argument optional

- improve documentation

Align XoWiki UI naming to that currently in xowiki.pretty_name

Mark flags as required

- fix file handling of SQL files

- add counting of blank lines

- add counting of comment lines

Trailing whitespace cleanup

whitespace changes

Let the teardown code take care of removing the site nodes (fixes tests on a vanilla core-only instance)

Unnest list idiom when we retrieve the url by package id in non-xotcl site node implementation (fixes tests on a vanilla instance with just the core packages)

undo previous change, problem was solved more generically in form-field-procs.tcl

    • -27
    • +0
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
whitespace changes

improve indentation

    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Fix behavior, in case a default value was provided for a checkbox part of a compound field.

When the user resets this default (i.e. clears the checkmark) no data is

transmitted from the browser, but the client side has to handle this. Such cases were

so far only handled so far outside of compound fields.

Example as give my Michael Aram (many thanks!):

# Class create mycompound -superclass CompoundField

#

# mycompound instproc initialize {} {

# if {${:__state} ne "after_specs"} return

# :create_components [subst {

# {start_on_publish {checkbox,default=t,options={YES t}}}

# {whatever {text}}

# }]

# set :__initialized 1

# }