• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
use consistently xowiki.css variants based on the preferred CSS toolkit

    • -2
    • +1
    /openacs-4/packages/xowiki/lib/view.tcl
    • -2
    • +0
    /openacs-4/packages/xowiki/www/admin/list.adp
    • -1
    • +5
    /openacs-4/packages/xowiki/www/admin/list.tcl
Make sure package_id is set on transcripts also when flushing messages every day

Chat reform:

- use consistently package_id to model belonging of a chat object to a particular package instead of the context_id

- set context_id to the package_id, as was already the case in practice, for permission checking

- make sure package_id exists and set it to the context_id in case it doesn't to handle legacy installations

    • -2
    • +2
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -2
    • +2
    /openacs-4/packages/chat/www/index.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/room-edit.tcl
make selection_area CSP compliant

reduce verbosity

Fix documentation

white-space cleanup

Improve robustness against "foreign" dnd operations

(when e.g. other, non-related elements on a web-site are dnd enabled and dragged into

a dnd-list)

white-space cleanup

    • -32
    • +32
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
add support for dnd on the toplevel list

YUI cleanup:

- remove dependency of TreeRenderer=listdnd on YUI and use basic HTML5 functionality

for drag and drop instead

- base toc with "allow_reorder" on TreeRenderer=listdnd

(yui-page-order-region.js is mostly obsolete by now)

    • -27
    • +77
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
file listdnd.js was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/xowiki/www/resources/listdnd.js
Prefer glyph-icons over sprites:

- new function xowiki::Package preferredCSSToolkit to ease access to preferred CSS toolkit

- split xowiki.css into a generic part (xowiki.css) and a preferred toolkit related part

(e.g.xowiki-bootstrap3-specific.css)

- use glyphicons in bootstrap variant instead of sprites for edit/delete/... buttons

    • -4
    • +10
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -2
    • +23
    /openacs-4/packages/xowiki/tcl/resource-init.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
file xowiki-bootstrap3-specific.css was initially added on branch oacs-5-10.

file xowiki-yui-specific.css was initially added on branch oacs-5-10.

improve wording for clipboard entries in menubar pulldown

break long lines

    • -2
    • +6
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
improve comments and indentation

make handling of form parameters more uniform

    • -5
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
template::add_event_listener: use more compact form in most simple cases

replaced YUI dnd by HTML5 dnd and therefor removed need of YUI in candidate_box_select.

candidate_box_select uses now clear distinction between internal representations and labels (as in options).

form-field of "form_page" uses now item-refs as internal representation since this relatively friendly to

clipboard movements and supports elements from different folders (which was previously broken).

file selection-area.js was initially added on branch oacs-5-10.

Further performance improvement: as we only want one column from xowiki_form_page, just get it through a subquery

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
xowiki_form_instance_item_view performance improvement: do not join with dummy cr_text table, use lateral on Postgres to better guide the query planner

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -5
    • +34
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Fix properly import/export in a way that, as we did before, context_id of imported objects will use cr_items default, the parent_id

    • -10
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
xowiki_form_instance_item_view reform: retrieve the context_id from the cr_item, rather than from the cr_revision

Rationale: revision's context_id is always set to its item_id. This will make every fetched ORM object appear as its context_id = item_id, while item's acs_object will display the correct context_id (in most cases, its parent)

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Keep previous behavior of ignoring the context_id when exporting/importing xowiki objects now that this metadata would be persisted

    • -1
    • +11
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Fix documentation (complete list of array fields)

Fix documentation (without a trailing slash, a redirect will happen, which transforms the POST into a GET request, which then will not be processed)

    • -2
    • +2
    /openacs-4/packages/xml-rpc/www/doc/index.adp
prefer absolut object references over ids

    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -10
    • +11
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
    • -6
    • +6
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/weblog-procs.tcl
    • -10
    • +10
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl