• last updated 16 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Add new private proc 'attachments::get_attachments_url', and use it to complement the logic of 'attachments::get_url'

As 'attachments::get_url' returns the value of the attachments package

'RelativeUrl' parameter, which can change at any time, it could happen

that previously mounted attachments have a different url and are not

found anymore.

We try our best here to find a mounted attachments package under

'base_url' to mitigate this, probably flawed, package logic.

In the future, probably a better method should be used for URL resolving

that is not so broken.

The whole thing is even more weird, as the attachments package is

currently a singleton that auto-mounts on /attachments, so i am tempted

to replace this whole thing with just that, but anyway...

Use 'attachments::detach_url' instead of building manually the URL

ensure ::xo::cc is available

Deprecate trivial empty_string_p

Bump version to reload message keys

Renaming of files so they are loaded after 00-icanuse-procs.tcl

    • -3800
    • +0
    • -0
    • +3800
file 01-database-procs-oracle.tcl was initially added on branch oacs-5-10.

file 01-database-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
file 01-database-procs-postgresql.tcl was initially added on branch oacs-5-10.

file 01-database-procs-postgresql-postgresql.xql was initially added on branch oacs-5-10.

    • -0
    • +0
use creation_user parameter on save_new, so that the party_id is recognized as creation_user

    • -2
    • +1
Localize some pretty names. Many thanks to Monika Andergassen

fix typo in filename and use opportunity to rename the proc after the API call.

file 00-icanuse-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
use the random number generator from OpenSSL, when available

don't write sensitive information into log files

Do not add the language prefix when the lookup already found exactly the page we were trying to reference (complies with current automated tests)

    • -3
    • +4
Fix typo

Fix typos

improve spelling

add "parent_id" to the list of excluded vars in "copy_content_vars" (as suggested by KM)

    • -1
    • +2
make sure, the dump fiile does not grow infinitely

fix typo

Remove form debug code

Forum attachments reform.

- Add new style of attachments to the forums, allowing multiple attachments to a single message directly from the message post page, using the multiple file input widget.

- Retain compatibility with old style attachments, using the new 'AttachmentStyle' package instance parameter. Currently, this supports two values: 'simple' (new behavior) and 'complex' previous behavior.

- Both attachment styles can coexist, and attachments added by any of such methods will be shown.

- Improve the contract on 'forums/lib/message/post.tcl'.

- Show attachments on message preview.

- Bump version number.

    • -2
    • +3
Check if an upload file was supplied when validating

Bump version number

Small step in the direction of gender-neutral German localization so we don't have to create a downstream message key just for this

improve spelling

Add 'alt_template' to include contract