• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Pass to a ns_cache implementation to avoid race conditions

    • -14
    • +22
    ./acs-tcl/tcl/community-core-procs.tcl
Implement acs_user:: cache through nsv, instead of the util_memoize cache. Note that now this information won't expire anymore unless explicitly flushed.

    • -12
    • +19
    ./acs-tcl/tcl/community-core-procs.tcl
Remove unnecessary backslashes, remove leftover usages of get_from_username_not_cached cache, minimize catch wrapping

    • -9
    • +11
    ./acs-tcl/tcl/community-core-procs.tcl
Reuse acs_user::get_by_username to retrieve user_id in order to reduce query duplication and cache entries for acs_user::get, simplify idiom

    • -32
    • +11
    ./acs-tcl/tcl/community-core-procs.tcl
    • -38
    • +1
    ./acs-tcl/tcl/community-core-procs.xql
Repair broken link: refer to page 'object' instead of to page 'list'

Fix missing variable substitution

    • -2
    • +2
    ./forums-portlet/www/forums-portlet.tcl
Dont require role at the ends of relationships as this is not required in the data model and standard relationships (e.g. membership_rel, admin_rel) lack these roles as well

Fix page for deleting roles

minor changes for consistency

    • -1
    • +1
    ./dotlrn-catalog/tcl/dotlrn-catalog-procs.tcl
    • -3
    • +3
    ./dotlrn-ecommerce/www/applications.tcl
improve documentation

    • -1
    • +1
    ./acs-core-docs/www/docbook-primer.adp
    • -10
    • +8
    ./acs-core-docs/www/release-notes.adp
    • -3
    • +3
    ./acs-core-docs/www/releasing-openacs-core.adp
    • -2
    • +2
    ./acs-core-docs/www/releasing-openacs-core.html
add workflow instance in test workflow

    • -14
    • +51
    ./xowf/tcl/test/xowf-test-procs.tcl
strengthen page contracts a little.

Add missing brace

Transform page_contract into include_contract, and add 'session_id' required parameter for the 'find_assessment' query

Create 'ad_include_contract' for includelet

    • -140
    • +156
    ./assessment/lib/session-items.tcl
Fix typo

Fix typo

Rework adp boolean expressions

    • -1
    • +1
    ./assessment/www/assessment-section-submit.adp
    • -1
    • +1
    ./assessment/www/assessment-single-submit.adp
    • -1
    • +1
    ./calendar-portlet/www/calendar-list-portlet.adp
    • -1
    • +1
    ./calendar-portlet/www/calendar-portlet.adp
    • -1
    • +1
    ./categories/www/cadmin/tree-delete.adp
    • -1
    • +1
    ./forums-portlet/www/forums-admin-portlet.adp
    • -1
    • +1
    ./fs-portlet/www/fs-contents-portlet.adp
    • -1
    • +1
    ./general-comments/www/view-comment.adp
  1. … 11 more files in changeset.
Prefer literal in adp expressions + Whitespace changes

    • -1
    • +1
    ./file-storage-includelet/lib/file-storage-admin-includelet.adp
    • -7
    • +7
    ./file-storage-includelet/lib/file-storage-includelet.adp
    • -1
    • +1
    ./forums-includelet/lib/forums-admin-includelet.adp
    • -1
    • +1
    ./forums-includelet/lib/forums-includelet.adp
Brace and rework expressions + Whitespace changes

    • -3
    • +3
    ./acs-ldap-authentication/tcl/ldap-procs.tcl
    • -1
    • +1
    ./acs-templating/www/doc/gen/generate-docs.tcl
    • -1
    • +1
    ./bug-tracker/tcl/bug-tracker-procs.tcl
    • -1
    • +1
    ./calendar-portlet/tcl/test/calendar-portlet-procs.tcl
perform proper boolean test (variable ends with "_p")

Revert unintended replacement

    • -1
    • +1
    ./acs-reference/www/view-one-reference.adp
Prefer literal in adp axpressions + Whitespace changes

    • -1
    • +1
    ./acs-reference/www/view-one-reference.adp
    • -10
    • +10
    ./acs-subsite/www/admin/relations/one.adp
    • -1
    • +1
    ./assessment/www/assessment-section-submit.adp
    • -41
    • +41
    ./assessment/www/asm-admin/item-add.adp
    • -7
    • +7
    ./calendar-portlet/www/calendar-list-portlet.adp
  1. … 15 more files in changeset.
Exploit users cache, simplify SQL

    • -2
    • +16
    ./forums/lib/forums/forums-history-chunk.tcl
    • -12
    • +0
    ./forums/lib/forums/forums-history-chunk.xql
Shorten expression, exploit cache

Prefer literal in adp axpressions

    • -5
    • +5
    ./assessment/www/assessment-section-submit.adp
    • -1
    • +1
    ./assessment/www/assessment-single-submit.adp
    • -6
    • +6
    ./general-comments/www/view-comment.adp
    • -5
    • +5
    ./new-portal/www/themes/deco-theme.adp
    • -9
    • +9
    ./new-portal/www/themes/nada-theme.adp
    • -11
    • +11
    ./new-portal/www/themes/simple-theme.adp
Streamline code

    • -12
    • +5
    ./acs-subsite/www/pvt/set-on-vacation-to-null.tcl
Simplify SQL expression

Remove broken portrait script from the old good days

Remove unneded variable (makes merging downstream easier)

    • -1
    • +1
    ./forums-portlet/www/forums-portlet.adp
    • -1
    • +0
    ./forums-portlet/www/forums-portlet.tcl