• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Trim whitespace

    • -3
    • +3
    ./news-aggregator/www/subscriptions.tcl
Repair form validation of URL

    • -5
    • +5
    ./news-aggregator/www/subscriptions.tcl
New test to check whether configured news feeds look ok

    • -2
    • +2
    ./news-aggregator/tcl/source-procs.tcl
Fix typo or this file would not load

    • -1
    • +1
    ./acs-lang/tcl/test/acs-lang-test-procs.tcl
fix typo

Trim whitespace

    • -2
    • +2
    ./news-aggregator/tcl/install-procs.tcl
Fix typo

    • -1
    • +1
    ./acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
Replace array idioms with dict idioms

    • -24
    • +20
    ./acs-tcl/tcl/site-nodes-procs.tcl
whitespace changes

    • -3
    • +3
    ./acs-automated-testing/tcl/aa-test-procs.tcl
since test case ids are only significant per package_key, record such pairs in procdoc data structure

    • -4
    • +9
    ./acs-automated-testing/tcl/aa-test-procs.tcl
don't raise error on wrong inputs

    • -1
    • +6
    ./acs-automated-testing/www/admin/testcase.tcl
Display warnings in the test results page

    • -3
    • +15
    ./acs-automated-testing/www/admin/index.adp
    • -20
    • +28
    ./acs-automated-testing/www/admin/index.tcl
improve testcases by removing useless expr commands

    • -1
    • +1
    ./new-portal/tcl/test/new-portal-test-procs.tcl
    • -5
    • +5
    ./oacs-dav/tcl/test/oacs-dav-procs.tcl
    • -10
    • +10
    ./views/tcl/test/views-procs.tcl
    • -3
    • +3
    ./workflow/tcl/test/workflow-test-procs.tcl
update tutorial: don't recommend to use "expr" for aa_true or aa_false

procdoc change: Preserve pre-existing values, e.g. from testcases, which might be loaded in a different order (testcase might be loaded before proc)

.CVS: ----------------------------------------------------------------------

    • -2
    • +16
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
improve testcases by removing useless expr commands

    • -3
    • +7
    ./acs-admin/tcl/test/acs-admin-procs.tcl
    • -19
    • +19
    ./acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -21
    • +21
    ./acs-authentication/tcl/test/sync-test-procs.tcl
    • -3
    • +3
    ./acs-content-repository/tcl/test/acs-content-repository-procs.tcl
    • -2
    • +2
    ./acs-content-repository/tcl/test/content-folder-test-procs.tcl
    • -10
    • +10
    ./acs-content-repository/tcl/test/content-image-test-procs.tcl
    • -15
    • +15
    ./acs-content-repository/tcl/test/content-item-test-procs.tcl
    • -2
    • +2
    ./acs-content-repository/tcl/test/content-keyword-test-procs.tcl
    • -6
    • +6
    ./acs-content-repository/tcl/test/content-revision-test-procs.tcl
    • -4
    • +4
    ./acs-content-repository/tcl/test/content-search-procs.tcl
    • -7
    • +7
    ./acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -2
    • +2
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
    • -11
    • +11
    ./acs-templating/tcl/test/spell-checker-procs.tcl
    • -2
    • +2
    ./dotlrn-ecommerce/tcl/test/dotlrn-ecommerce-procs.tcl
    • -5
    • +5
    ./dotlrn-fs/tcl/test/dotlrn-fs-procs.tcl
  1. … 3 more files in changeset.
make tested procs explicit

    • -10
    • +101
    ./acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -15
    • +94
    ./acs-authentication/tcl/test/sync-test-procs.tcl
improve testcases by removing useless expr commands

    • -3
    • +3
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -7
    • +7
    ./acs-tcl/tcl/test/ad-proc-test-procs.tcl
    • -14
    • +14
    ./acs-tcl/tcl/test/application-data-link-procs.tcl
    • -3
    • +6
    ./acs-tcl/tcl/test/doc-check-procs.tcl
    • -16
    • +16
    ./acs-tcl/tcl/test/test-permissions-procs.tcl
    • -5
    • +5
    ./acs-tcl/tcl/test/whos-online-procs.tcl
make feedback from testruns nicer (remove redundant messages)

    • -10
    • +8
    ./acs-automated-testing/tcl/aa-test-procs.tcl
Declass constraint names breaking the very strict OpenACS naming convention from errors to warnings

Rationale: it is sometimes impossible to have constraint names that are both < 30 chars and consistent with the naming scheme 'table_name'_'column_name'_'constraint_type' for all those defined on a particular table (see e.g. acs_named_objects).

Breaking this convention might be suboptimal, but is not harmful in itself.

    • -2
    • +2
    ./acs-tcl/tcl/test/datamodel-test-procs.tcl
flush per-request cache (fixes regression test properly)

simplify code

    • -3
    • +2
    ./acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
improve testcase viewing page:

- use syntax highlighting to testcase body

- fix label for body:

* just use numbering when appropriate

* start numbering of bodies with 1

    • -2
    • +3
    ./acs-automated-testing/www/admin/testcase.adp
    • -12
    • +11
    ./acs-automated-testing/www/admin/testcase.tcl
improve test cases: align comment with operations, remove useless "expr" commands

    • -25
    • +26
    ./acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
improve log message to be able to distinguish between multiple commands with different parameters

Make string_truncate behave as before (looking for spaces at end_position + 1) and therefore not breaking tests for ad_html_text_convert. Update docs so this property of being less or equal than len is clearly specified

Revert change... more investigation needed

Trim whitespace

    • -34
    • +33
    ./acs-tcl/tcl/acs-cache-procs.tcl
node_id shoudl probably be parent_id (fixes automated tests)

Trim whitespace

    • -10
    • +10
    ./acs-tcl/tcl/test/site-nodes-test-procs.tcl