• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve spelling

- adjust to changed results of ns_cache_stats

- add comments and warnings

    • -17
    • +32
    ./tcl/authentication-procs-naviserver.tcl
use public interface instead of private one

    • -2
    • +2
    ./tcl/test/acs-authentication-procs.tcl
Provide an ad_include_contract for the page (fixes files__page_contracts)

Ehm.. revert previous commit: search would use service contract to get the search form, so we should no assume local-search to be used...

  1. … 1 more file in changeset.
Removal of obsolete user search includes

Rationale:

- no mention to these pages anywhere in upstream packages

- local-search fails files__page_contracts automated test

- weird code in local-search (where is authority_id used to filter users?...)

- acs-admin/users/complex-search is a working replacement and duplicates their intended features

- as for TIP#125, in case complex-search was not reusable, probably a minor rework would do

  1. … 1 more file in changeset.
Trim whitespaces

Indentation change

Harmonize parameter names in proc documentation removing unexistent ones

handle authorizations with no auth_sync_process defined without raising an error in the error.log

Remove ns_parseurl from list of tested procs, as not being a openacs proc will trigger an error at load time

Test also the portrait api (exploit the fact that we are already creating bogus users), move helper procs to the beginning so they can be found by the testing machinery

    • -28
    • +53
    ./tcl/test/acs-authentication-procs.tcl
Trim whitespace

    • -64
    • +64
    ./tcl/test/acs-authentication-procs.tcl
improve testcases by removing useless expr commands

    • -19
    • +19
    ./tcl/test/acs-authentication-procs.tcl
  1. … 16 more files in changeset.
make tested procs explicit

    • -10
    • +101
    ./tcl/test/acs-authentication-procs.tcl
  1. … 1 more file in changeset.
improve rowcount expressions

  1. … 76 more files in changeset.
Fix typos

  1. … 10 more files in changeset.
improve spelling

  1. … 12 more files in changeset.
Fix test on system having 0.0.0.0 as IPv4 address in the config file

Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @parameter -> @param

- @params -> @param

- Add missing @param

- @cvs -> @cvs-id

- @version -> @cvs-id

  1. … 12 more files in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

    • -1
    • +1
    ./tcl/authentication-procs-aolserver.tcl
    • -1
    • +1
    ./tcl/authentication-procs-naviserver.tcl
  1. … 367 more files in changeset.
Apply new api where appropriate

Exploit new api where appropriate

Apply new user api when appropriate

Rework of this tests

- use dict idioms instead of array, so we don't have to unset all the time

- use new user api when appropriate

- fix test when we try to reuse the username of somebody who was previously banned.

This is no longer possible and is now reflected in the test

Update es_ES translation

    • -0
    • +1
    ./catalog/acs-authentication.es_ES.ISO-8859-1.xml
  1. … 3 more files in changeset.
Fix typo and add missing italian translation

    • -1
    • +1
    ./catalog/acs-authentication.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-authentication.it_IT.ISO-8859-1.xml
Fix typos

  1. … 1 more file in changeset.
Fix wording

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

    • -1
    • +1
    ./tcl/authentication-procs-aolserver.tcl
    • -1
    • +1
    ./tcl/authentication-procs-naviserver.tcl
    • -2
    • +2
    ./tcl/test/acs-authentication-procs.tcl
  1. … 469 more files in changeset.