• last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove type discrepancy introduced in 2002:

- acs_object_types.object_type has type varchar(1000), while

- acs_object_types.supertype has type varchar(100)

... several more data types are involved, using acs_object_types.object_type as foreign key

  1. … 5 more files in changeset.
- fix install scripts

  1. … 1 more file in changeset.
- second part of Part 4 of OpenACS 5.9 agenda: get rid of tree_sortkey in acs-objects : getting rid of functions accessing acs_objects.tree_sortkey when creating new instances

- use variable names "ot1" and "ot2" instead of "o1" and "o2" when referring to object_types (and not objects)

  1. … 1 more file in changeset.
- scalability reform part 1

* remove manual delete operations from acs_object__delete()

where update is as achieved automatcially via cascade operations

* improve documentation of source code

- bump version number to 5.9.0d2

  1. … 2 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- fixing 2 more cases of still incorrect function argument names

  1. … 3 more files in changeset.
- fix function args: names of arguments for postgres did not match names for oracle leading to potential portability problems

  1. … 1 more file in changeset.
Bring PostgreSQL functions closer to the current level of PL/pgSQL:

- upgrade PL/pgSQL functions to the $$ notation (recommended since pg8.0, jan 2005).

- get rid of backslash usages in function definitions

- drop aliases in favor of named function arguments (recommended since pg8.0)

- fix wrong function_args, add missing function_args, align default semantics

with the defaults in pg (providing "null" as default means the argument is

optional).

- change return types of triggers from "opaque" to "trigger" (recommended since pg8.0)

- unify names of triggers *_tr

- removed some version dependencies of pg 7.2 and 7.3

  1. … 54 more files in changeset.
Merged oacs-5-6 to HEAD. HEAD now installs and passes all core tests. There

may still be some lingering problems due to my screwing up the oacs-5-6

branch earlier, I'll be looking into this later.

  1. … 214 more files in changeset.
Changes for supporting postgresql 9.0:

- Avoiding usage of SQL reserved keywords on plpsql functions (plpsql lexer and parser were reworked).

- Fixing all those places on which FROM clause was automatically added by PG ( PG Config add_missing_from parameter was removed for this release of PG ).

Many thanks to Tracy Adams and Jeff Lu for providing first version of the patches.

  1. … 16 more files in changeset.
Somebody hosed this (probably me). Never caught because no one creates a

base object directly, just subtypes of acs_object with their own (correct)

definition of a new() function.

- complete change to acs_objects_package_idx for new creates (see http://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-6%3Agustafn%3A20100509112929)

  1. … 1 more file in changeset.
1. Changed trigger functions from "opaque" to "trigger" to get rid of the

warnings during initial install (only for acs-kernel, there are a lot

elsewhere!)

2. Added "embeds" for postgresql and partially for oracle.

3. Added global parameters for postgresql and partially for oracle.

(oracle will be forthcoming shortly)

  1. … 29 more files in changeset.
Added some missing attributes (more to go, though, damn core datamodel)

  1. … 3 more files in changeset.
Someone didn't realize that "foo;null" in define_function_args calls sets the

default value to 'null' not NULL...this has been there a long time ... maybe

even my fault, but I don't remember, it's ancient!

  1. … 1 more file in changeset.
- Add two missing indices to improve performance of permission system

and the object context hierarchy significantly (these two indices

improved the performance of e.g. /projects/openacs/download/ and

/projects/openacs/download/one-revision?revision_id=2089636 by more

than a factor of 10; these indices are now among the most used on

openacs.org)

- Bump version number

  1. … 5 more files in changeset.
Get rid of the postgres warning "adding missing FROM-clause entry " on sequences

Make "db_nextval acs_object_id_seq" more than twice as fast (from 948 microseconds to 378 microseconds)

  1. … 9 more files in changeset.
adding missing function args, fixing incorrect function args, including upgrade script

  1. … 3 more files in changeset.
Correction of name constraint

  1. … 13 more files in changeset.
Realized that I only need to define function args for the most verbose

form of acs_object__new, since package_instantiate_object handles

default values very nicely.

  1. … 1 more file in changeset.
A variety of group oriented things, and finally added the definitions of

acs-objects package procs in PG so that we can use package_instantiate_object

and package_db_exec with them.

  1. … 10 more files in changeset.
preserve last_modified when explicitly updated, replaces acs_objects_last_mod_update_tr, bump version, upgrade scripts

  1. … 4 more files in changeset.
fix the static cvs-id tags

  1. … 32 more files in changeset.
minor typo prevented setting title even if provided in acs_object__new

Remerge Timo's changes for tip 42,43, cf tip 53

  1. … 97 more files in changeset.
rollback of Timo's name, package_id commit; see TIP 53

  1. … 96 more files in changeset.
TIP#42,43: adding package_id and title to acs_objects table

  1. … 96 more files in changeset.
integrity violation fix for acs_object__delete function. Making it delete matching acs_permission.grantee_id records in addition to the object_id ones. Bumping version of kernel to 5.0.0b5

  1. … 4 more files in changeset.
merge of changes on oacs-5-0 branch to oacs-5-0-0b4 tag

  1. … 598 more files in changeset.
Addresses bug 1148, bug 1149 (and performance problems generally with plpgsql functions).

eliminate with(isstrict,iscachable) in favor of the new syntax strict, immutable, stable.

bump version of acs-kernel, acs-content-repository to 5.0.0b4, upgrade scripts provided.

Fix bugs with the following plpgsql procs:

acs_object__initialize_attributes: raise exception on null input.

acs_object__set_attribute: exception on null input

acs_object_util__get_object_type: remove the exception after the return statement

apm__unregister_package: properly default cascade_p

apm__unregister_service: properly default cascade_p

content_item.get_parent_folder: infinite loop on input if not a direct descendent of a folder (fixed on oracle too)

content_item__get_context: exception on null input, fix bug in exception print (wrong variable name)

content_item__is_publishable: returned t on null and invalid items

content_item__is_subclass: did not short curcuit loop when subclass found

content_item__move: would silently ignore null target_id

content_revision__copy_attributes: generate an exception on null input

content_revision__export_xml: generate exception if called (unimplemented in postgres)

content_symlink__copy: generate exception if called (unimplemented)

apm_package__parent_id: returned -1 on not found rather than null

content_folder__is_registered: no default provided in code for include_subtypes

content_keyword__is_assigned: no default for recurse...

content_revision__import_xml: generate exception if called (unimplemented in postgres)

content_revision__index_attributes: generate exception if called (unimplemented in postgres)

content_type__trigger_insert_statement: now generates exception on null input (was silent failure)

number_src: infinite loop on null input

rule_exists: fix case folded lookup

Declare the following stable:

get_func_definition get_func_header acs_message__name

acs_object_type_insert_tr acs_message__message_p

acs_object_type__pretty_name acs_message__first_ancestor

acs_object_type__is_subtype_p acs_objects_get_tree_sortkey

acs_object__name acs_object__default_name

acs_object__get_attribute_storage acs_object__get_attribute

acs_object__check_path acs_mail_link__link_p

acs_object_util__object_type_exist_p acs_object_util__get_object_type

acs_object_util__type_ancestor_type_p

acs_object_util__object_ancestor_type_p acs_object_util__object_type_p

acs_rel_type__role_pretty_name acs_rel_type__role_pretty_plural

party__email person__name person__first_names person__last_name

application_group__group_id_from_package_id

acs_user__receives_alerts_p group_contains_p

acs_message_get_tree_sortkey acs_mail_body__body_p

acs_permission__permission_p acs_mail_multipart__multipart_p

content_keyword__get_heading acs_group__name acs_group__member_p

rel_segment__get rel_segment__name rel_constraint__get_constraint_id

rel_constraint__violation rel_constraint__violation_if_removed

content_keyword__get_description site_node_get_tree_sortkey

timezone__convert_to_local timezone__get_offset

timezone__get_rawoffset timezone__get_abbrev timezone__get_date

timezone__isdst_p rdbms_date apm__register_p timezone__get_id

doc__get_proc_header apm__parameter_p apm__id_for_name apm__get_value

apm__get_value apm_package__initial_install_p apm_package__singleton_p

apm_package__num_instances apm_package__name

apm_package__highest_version apm_package__parent_id

apm_package_type__num_parameters content_keyword__is_leaf

acs_sc_msg_type__get_id acs_sc_msg_type__get_name

acs_sc_contract__get_id acs_sc_contract__get_name

acs_sc_operation__get_id acs_sc_impl__get_id acs_sc_impl__get_name

acs_sc_binding__exists_p cr_items_get_tree_sortkey

content_keyword__is_assigned content_keyword__get_path

content_template__is_template cr_keywords_get_tree_sortkey

content_template__get_path table_exists column_exists trigger_exists

trigger_func_exists rule_exists content_folder__is_registered

content_folder__get_label content_folder__get_index_page

content_type__get_template content_type__trigger_insert_statement

content_type__is_content_type content_item__get_root_folder

content_item__is_published content_item__is_publishable

content_item__is_valid_child content_item__get_id

content_item__get_template content_item__get_content_type

content_item__get_live_revision content_item__get_revision_count

content_item__get_context content_item__get_latest_revision

content_item__get_best_revision content_item__get_title

content_item__get_title content_item__get_publish_date

content_item__is_subclass content_item__is_index_page

content_item__get_parent_folder content_revision__get_number

content_revision__revision_name content_revision__is_latest

content_revision__get_content content_symlink__is_symlink

content_symlink__resolve_content_type content_extlink__is_extlink

content_folder__is_folder content_folder__is_empty

file_storage__get_root_folder file_storage__get_package_id

forums_message__root_message_id content_symlink__resolve

  1. … 42 more files in changeset.