• last updated 15 mins ago
Constraints: committers
Constraints: files
Constraints: dates
improve comments and spelling

  1. … 4 more files in changeset.
Fix typos

  1. … 12 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

    • -205
    • +317
  1. … 7834 more files in changeset.
Fix spelling errors

  1. … 48 more files in changeset.
- Improved compatiblity with PostgreSQL before 9.2:

don't use SQL-language function names to reference parameters to

obtain compatibility for earlier PostgreSQL versions

(see https://www.postgresql.org/docs/9.2/static/release-9-2.html

item E.

  1. … 1 more file in changeset.
- improve source code documentation

- added new function acs_permission.permissions_all as replacement for acs_permssions_all

- removed all dependencies on acs_permssions_all in kernel (such that acs_object_paths and acs_object_context_index can be dropped for PostgreSQL)

  1. … 8 more files in changeset.
- change language of function from plpgsql to sql to avoid mismatch

  1. … 1 more file in changeset.
- Add SQL schema acs_permission to allow to call sql-functions for

Oracle and PostgreSQL in exactly the same way

- Move postgres permission function to the new neamespace and provide

stubs for backward compatibility

- New function permission::get_parties_with_permission

to support a restricted form of reverse lookup for permssions

in order to reduce the dependencies on

acs_object_party_privilege_map for PostgreSQL

- make upgrade scripts more robust (support repeated loading)

- bump verison number of acs-tcl to 5.9.1d9

- bump version number of acs-kernel to 5.9.1d11

  1. … 12 more files in changeset.
- replace obsolete all_object_party_privilege_map by acs_object_party_privilege_map

- bump version number to 5.9.1d10

  1. … 6 more files in changeset.
- Slightly faster (around 10%) versions for the base permission query functions.

In the new versions the lookup of acs__magic_object_id was moved out of the loop.

    • -175
    • +141
  1. … 2 more files in changeset.
Removed exclusive lock from permission granting and revoking. Use exception handling or ignoring instead, as in Oracle codebase.

  1. … 2 more files in changeset.
Creating recursive version of permissions functions iff pg version is >= 8.4.

  1. … 3 more files in changeset.
Renaming parameters used on recursive query in order to avoid name clashing with function parameters ( seems to happen just in pg 8.4 ).

  1. … 1 more file in changeset.
Rewriting acs_permission__permission_p function to use recursive queries ( available in PG since 8.4 ) and modifiying

queries around core packages to avoid checking persmissions using a subquery on the acs_object_party_privilege_map view.

  1. … 14 more files in changeset.
Bring PostgreSQL functions closer to the current level of PL/pgSQL:

- upgrade PL/pgSQL functions to the $$ notation (recommended since pg8.0, jan 2005).

- get rid of backslash usages in function definitions

- drop aliases in favor of named function arguments (recommended since pg8.0)

- fix wrong function_args, add missing function_args, align default semantics

with the defaults in pg (providing "null" as default means the argument is


- change return types of triggers from "opaque" to "trigger" (recommended since pg8.0)

- unify names of triggers *_tr

- removed some version dependencies of pg 7.2 and 7.3

  1. … 54 more files in changeset.
1. Changed trigger functions from "opaque" to "trigger" to get rid of the

warnings during initial install (only for acs-kernel, there are a lot


2. Added "embeds" for postgresql and partially for oracle.

3. Added global parameters for postgresql and partially for oracle.

(oracle will be forthcoming shortly)

  1. … 29 more files in changeset.
- Add two missing indices to improve performance of permission system

and the object context hierarchy significantly (these two indices

improved the performance of e.g. /projects/openacs/download/ and

/projects/openacs/download/one-revision?revision_id=2089636 by more

than a factor of 10; these indices are now among the most used on


- Bump version number

  1. … 5 more files in changeset.
Merged the 5.3 branch with HEAD. Look for tags with the pattern


  1. … 324 more files in changeset.
bumping version numbers and create an additional index to speed up permission checking

  1. … 4 more files in changeset.
create an additional index to speed up permission checking

  1. … 2 more files in changeset.
Correction of name constraint

  1. … 13 more files in changeset.
A variety of group oriented things, and finally added the definitions of

acs-objects package procs in PG so that we can use package_instantiate_object

and package_db_exec with them.

  1. … 10 more files in changeset.
fix the static cvs-id tags

  1. … 32 more files in changeset.
merge of changes on oacs-5-0 branch to oacs-5-0-0b4 tag

  1. … 598 more files in changeset.
Addresses bug 1148, bug 1149 (and performance problems generally with plpgsql functions).

eliminate with(isstrict,iscachable) in favor of the new syntax strict, immutable, stable.

bump version of acs-kernel, acs-content-repository to 5.0.0b4, upgrade scripts provided.

Fix bugs with the following plpgsql procs:

acs_object__initialize_attributes: raise exception on null input.

acs_object__set_attribute: exception on null input

acs_object_util__get_object_type: remove the exception after the return statement

apm__unregister_package: properly default cascade_p

apm__unregister_service: properly default cascade_p

content_item.get_parent_folder: infinite loop on input if not a direct descendent of a folder (fixed on oracle too)

content_item__get_context: exception on null input, fix bug in exception print (wrong variable name)

content_item__is_publishable: returned t on null and invalid items

content_item__is_subclass: did not short curcuit loop when subclass found

content_item__move: would silently ignore null target_id

content_revision__copy_attributes: generate an exception on null input

content_revision__export_xml: generate exception if called (unimplemented in postgres)

content_symlink__copy: generate exception if called (unimplemented)

apm_package__parent_id: returned -1 on not found rather than null

content_folder__is_registered: no default provided in code for include_subtypes

content_keyword__is_assigned: no default for recurse...

content_revision__import_xml: generate exception if called (unimplemented in postgres)

content_revision__index_attributes: generate exception if called (unimplemented in postgres)

content_type__trigger_insert_statement: now generates exception on null input (was silent failure)

number_src: infinite loop on null input

rule_exists: fix case folded lookup

Declare the following stable:

get_func_definition get_func_header acs_message__name

acs_object_type_insert_tr acs_message__message_p

acs_object_type__pretty_name acs_message__first_ancestor

acs_object_type__is_subtype_p acs_objects_get_tree_sortkey

acs_object__name acs_object__default_name

acs_object__get_attribute_storage acs_object__get_attribute

acs_object__check_path acs_mail_link__link_p

acs_object_util__object_type_exist_p acs_object_util__get_object_type


acs_object_util__object_ancestor_type_p acs_object_util__object_type_p

acs_rel_type__role_pretty_name acs_rel_type__role_pretty_plural

party__email person__name person__first_names person__last_name


acs_user__receives_alerts_p group_contains_p

acs_message_get_tree_sortkey acs_mail_body__body_p

acs_permission__permission_p acs_mail_multipart__multipart_p

content_keyword__get_heading acs_group__name acs_group__member_p

rel_segment__get rel_segment__name rel_constraint__get_constraint_id

rel_constraint__violation rel_constraint__violation_if_removed

content_keyword__get_description site_node_get_tree_sortkey

timezone__convert_to_local timezone__get_offset

timezone__get_rawoffset timezone__get_abbrev timezone__get_date

timezone__isdst_p rdbms_date apm__register_p timezone__get_id

doc__get_proc_header apm__parameter_p apm__id_for_name apm__get_value

apm__get_value apm_package__initial_install_p apm_package__singleton_p

apm_package__num_instances apm_package__name

apm_package__highest_version apm_package__parent_id

apm_package_type__num_parameters content_keyword__is_leaf

acs_sc_msg_type__get_id acs_sc_msg_type__get_name

acs_sc_contract__get_id acs_sc_contract__get_name

acs_sc_operation__get_id acs_sc_impl__get_id acs_sc_impl__get_name

acs_sc_binding__exists_p cr_items_get_tree_sortkey

content_keyword__is_assigned content_keyword__get_path

content_template__is_template cr_keywords_get_tree_sortkey

content_template__get_path table_exists column_exists trigger_exists

trigger_func_exists rule_exists content_folder__is_registered

content_folder__get_label content_folder__get_index_page

content_type__get_template content_type__trigger_insert_statement

content_type__is_content_type content_item__get_root_folder

content_item__is_published content_item__is_publishable

content_item__is_valid_child content_item__get_id

content_item__get_template content_item__get_content_type

content_item__get_live_revision content_item__get_revision_count

content_item__get_context content_item__get_latest_revision

content_item__get_best_revision content_item__get_title

content_item__get_title content_item__get_publish_date

content_item__is_subclass content_item__is_index_page

content_item__get_parent_folder content_revision__get_number

content_revision__revision_name content_revision__is_latest

content_revision__get_content content_symlink__is_symlink

content_symlink__resolve_content_type content_extlink__is_extlink

content_folder__is_folder content_folder__is_empty

file_storage__get_root_folder file_storage__get_package_id

forums_message__root_message_id content_symlink__resolve

  1. … 42 more files in changeset.
Merged with 4.6 branch

  1. … 30 more files in changeset.
1. removed some needless LARS notices

2. removed acs_methods and friends from the permissions documentation

and got rid of the commented-out table stubs.

3. dropping of permissions was broken in PG, fixed that.

4. cc_users and registered_users views have been sped up.

5. removed an unused and incorrect proc from revision-procs

6. updated acs-kernel to 4.6.3


  1. … 11 more files in changeset.
Migrated the 4.6.1 permissions stuff to HEAD

    • -318
    • +189
  1. … 7 more files in changeset.
Sped up the view used to build the denormalized acs_privilege_descendant_map


  1. … 1 more file in changeset.