• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix spelling errors

  1. … 48 more files in changeset.
Improve robustness of "file delete" operations

  1. … 19 more files in changeset.
Get rid of strange construct: [lindex [array get $array $name] 1]

  1. … 5 more files in changeset.
- no need to use backslash for continuation between curly brackets

- improve readability of code

- modernize tcl

  1. … 8 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 752 more files in changeset.
- remove globals for errorInfo and use namespace qualifiers instead

  1. … 15 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2546 more files in changeset.
- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

  1. … 12 more files in changeset.
- brace expressions to allow for tcl compilation

- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

  1. … 9 more files in changeset.
- extend localization test

- add test cases for lc_*

file acs-lang-localization-procs.tcl was initially added on branch oacs-5-8.

    • -0
    • +0
    ./acs-lang-localization-procs.tcl
Moved checks for semantic correctness of translation messages keys to the new proc lang::message::check,

introduced such proc into message edit form and in new regression test lang_messages_correct.

Added check to ensure localized separators for thousands and decimals are different. Equal separators

would have caused localized number parsing to fail.

  1. … 2 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
Test cases for lang-message-procs

    • -0
    • +33
    ./acs-lang-message-procs.tcl
merge all the changes on the oacs-5-1 and dotlrn-2-0 branches up to tag jcd-merge-20040420

  1. … 647 more files in changeset.
stripping off trailing space in the text of temporary tags on syntax <# key text #>. Checked new functionality with test case.

  1. … 1 more file in changeset.
Proc lang::message::format (used by lang::message::lookup) - implementing ability to have embedded array variables in I18N messages on syntax %var_name.key_name%. Adding corresponding test case.

  1. … 1 more file in changeset.
adding support for variables embedded in I18N messages to have the noquote instruction (from the corresponding adp variable). TODO: make sure we do ad_quotehtml and lang::util::localize on the embedded variables. Adding the proc convert_percentage_signs_to_adp_variables that we don't currently need, but I'm leaving it in in case it would be useful later on.

  1. … 3 more files in changeset.
adding the procs flag to the localize test case

merge the changes between 5.0.3 and 5.0.4 to head

  1. … 249 more files in changeset.
lang::util::localize wasn't working properly for multiple embedded message keys. I reworked the algorithm and added a test case for the proc. Thanks to Peter Alberer for reporting.

  1. … 1 more file in changeset.
Added categories to the automated test(s).

  1. … 10 more files in changeset.
merge of changes on oacs-5-0 branch to oacs-5-0-0b4 tag

  1. … 598 more files in changeset.
Adding support for I18N message catalog upgrades. Any import of

messages from catalog files that is done after the initial import is

considered an upgrade. The message import and upgrade logic is

encapsulated in the proc lang::catalog::import_messages (invoked

through lang::catalog::import).

acs-lang package

- Bumping version of package to 5.0.0b5

- Changes to datamodel:

- Adding columns deleted_p, conflict_p, and sync_time to lang_messages table.

- Removed column upgrade_status from lang_message_keys table

- Adding columns deleted_p, sync_time, conflict_p, upgrade_status to lang_messages_audit table

- Changes to lang::catalog Tcl API:

- Added proc lang::catalog::import_messages that encapsulates the logic for import and upgrade of

messages from catalog files to database.

- Changed the lang::catalog::import_from_file and lang::catalog:import procs to use the new import_messages proc.

- Added the upgrade Tcl API test cases that extensively tests through the import_messages proc with both

en_US and de_DE locales.

- Changes to lang::message Tcl API:

- Changed lang::message::register to take new switches upgrade_sync, upgrade_status, and conlfict. Cleaned up the

proc a little and made it construct SQL dynamically.

- Added procs delete, get, and get_element.

- Added the edit proc that is used when editing attributes of a message other than the message text itself. This

proc will not create a new message revision. It is invoked for example by the delete proc.

- Added the count_conflicts proc.

- Changes to admin UI

- New canonical pages for import/export of catalog files that check for site-wide-admin priv

- Made the message delete page use appropriate Tcl API

- Added the message-conflicts page that shows conflicting messages. Linking to this page from

index page, locale-, and package index pages.

acs-admin package

- Removed the import/export messages pages and using the ones in acs-lang package instead.

  1. … 44 more files in changeset.
Lars helped fix the check that variable in non-en_US messages are also in the corresponding en_US message. Replacing old get_missing_embedded_vars proc with the new get_embedded_vars proc and adding a bunch of test cases

  1. … 1 more file in changeset.
cleanup and renaming of import/export procs in lang::catalog namespace. Now there are really only two public procs to know about: lang::catalog::import and lang::catalog::export. Updating all invocations of the procs and test cases. Adding proc lang::message::unregister for deleting message keys - used in test case teardown.

  1. … 10 more files in changeset.
making the util_replace_temporary_tags_with_lookups test case pass again. Wrapping case in rollback. Some cleanup in the tested proc

  1. … 1 more file in changeset.
Fixed bug #941: lang::conn::timezone fails when not connected

  1. … 1 more file in changeset.
making sure danish locale is temporarily enabled for testcase to pass