• last updated 14 mins ago
Constraints: committers
Constraints: files
Constraints: dates
Redefine ad_locales.language table column as varchar to avoid Oracle idiosyncrasies when comparing a char(n) with other string datatypes when using bind variables (following insightful LARS's remark)

char(n) in Oracle are automatically padded to be n characters long. Apparently, comparing char(n) -> char(n) is "blanks insensitive", while comparing char(n) -> varchar2(n) will account for such automatically inserted blanks. When using bind variables, one should carefully specify the type to use to avoid surprises with char(n) (for this we should touch the oracle driver), normalize the value via trim/pad all the time or replace every char(n) datatype with varchar2. ...are there other places where this is happening?

  1. … 5 more files in changeset.
Rewrite the query to leverage transparent variable quoting, replace count with quicker existance check, bring sql inline

Switch to a sql-only approach (fixes regression)

Replace ad_decode idioms

  1. … 1 more file in changeset.
Replace ad_decode idioms

Bring files on oacs-5-10 in sync with HEAD

  1. … 162 more files in changeset.
Bring files on oacs-5-10 in sync with HEAD

  1. … 15 more files in changeset.
Whitespace changes + editor hints

  1. … 19 more files in changeset.
Replace/remove deprecated proc 'db_null' and update doc accordingly

  1. … 33 more files in changeset.
Fix typo in proc doc

don't load deleted messages into the cache and drop conceptually broken parameter

Fix typo

Replace silent catch with something nicer

Fulfill Lars old dream by using a thread safe idiom

Tolerate wrong locales from browsers by assuming our default one

improve spelling

  1. … 15 more files in changeset.
fix typos

Remove private proc 'lang::message::translate', broken since 2002 and used nowhere.

Remove deprecated proc 'ad_locale_get_label', scheduled to be removed in 5.3, and used nowhere.

Whitespace changes

Harmonize parameter names in proc documentation removing unexistent ones

Fix parameter names in proc doc

rework test cases, make tested procs explicit

    • -5
    • +9
    • -10
    • +16
    • -41
    • +115
Fix typo or this file would not load

improve testcases by removing useless expr commands

  1. … 17 more files in changeset.
Whitespace changes + add editor hints

  1. … 26 more files in changeset.
Remove superflous parentheses

  1. … 29 more files in changeset.
improve spelling

  1. … 11 more files in changeset.
improve spelling

  1. … 12 more files in changeset.
Delete thread cache variable as well when setting a new locale and use this corrected api to repair broken test