• last updated 47 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove unneeded test and improve documentation

Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

  1. … 15 more files in changeset.
- add nonces to script tags

- add body handlers

  1. … 7 more files in changeset.
- use for hex codes 2-digit notation \xHH to make it compatible for tcl8.6

  1. … 5 more files in changeset.
- fix spelling of variable name

- Make parsing of "Accept-Language" header fields more robust:

ignore spaces after the comma, ignore wildcard value "*"

- Accept locales as syntactically correct when these contain numeric values (such as e.g. "es_419" for “Latin American Spanish”).

Since lang::conn::valid_locale_p is used in lang::conn::get_accept_language_header, OpenACS throws exceptions

on invalid locales, these caused problem even when these are low on the preference list of the Accept-Language header field.

- allow empty locale cookie

- return the invalid cookie in the error

- add validator for locale (useful, when headers or locale-cookie were hacked)

- provide an error message for invalid locale values

- improve indentation

.xql-file reform of acs-lang

- remove unneeded sql queries

lang::catalog::reset_upgrade_status_message_keys.reset_status"

lang::catalog::import_from_file.reset_upgrade_status_messages

lang::catalog::import_from_file.mark_message_as_deleted

lang::catalog::import_from_file.mark_message_key_as_deleted

lang::message::register.message_exists_p

- add per-request caching of acs_translator_mode_p

- no need to use backslash for continuation between curly brackets

- improve readability of code

- modernize tcl

  1. … 8 more files in changeset.
- add dropped error message variable

- remove useless if-statement

- use ad_log for error reporting to ease debugging

- simplify regular expression code for message keys: use build in functionality of regexp

- fix type in documentation

- prefer ns_quotehtml over ad_quotehtml

  1. … 27 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

    • -0
    • +6
    ./test/acs-lang-localization-procs.tcl
  1. … 741 more files in changeset.
- remove globals for errorInfo and use namespace qualifiers instead

  1. … 14 more files in changeset.
- don't raise an error on missing substitution variables, but write an error to the error.log (otherwise, one can get recursive errors on missing variables)

- standardize url construction to protect against injection attacks

  1. … 9 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

    • -0
    • +58
    ./test/acs-lang-localization-procs.tcl
  1. … 2538 more files in changeset.
- change spelling of TCL to Tcl

- change requirements to Tcl 8.5

  1. … 64 more files in changeset.
- fix api-doc variable @creation-date

- fix invalid @param declaration for API browser

  1. … 4 more files in changeset.
- add missing .xql file

- don't spit out messages of the form "Key 'package_key.message_key' does not exist in en_US" when viewing proc lang::util::replace_temporary_tags_with_lookups in api-browser

- use util::http::get instead of ns_httpget

  1. … 2 more files in changeset.