• last updated 2 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Whitespace cleanup

Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

  1. … 2 more files in changeset.
whitespace changes

remove unused private function acs_object_type::acs_object_instance_of

fix broken API function acs_object_type::get_table_name (broken since 13 years) and use API instead of direct SQL queries

  1. … 6 more files in changeset.
Put redundant query definition into generic ones

Close select properly

Reuse existing api and streamline queries to reduce divergency between oracle and postgres codebase

Allow themeing of /packages/acs-tcl/lib/complain

make code more robust, when connection is already closed

improve spelling

  1. … 4 more files in changeset.

Re-enabling sec_change_user_auth_token as a mean to invalidate login for a user immediately on every connected client

For reference, see discussions in:

- https://openacs.org/forums/message-view?message_id=1691183

- https://openacs.org/forums/message-view?message_id=5392475

fix documentation (fix for #3345)

make indentation regular

Employ new user cache also for portrait information

Don't cache invalid user ids, as they might become valid shortly after (e.g. during registration)

flag current request as being performed via aa_testing

Use more API

add address to driver_info

  1. … 1 more file in changeset.
Remove unneded dict creation

  1. … 1 more file in changeset.
modernize tcl

  1. … 1 more file in changeset.
Modernize idiom

Restore previous behavior: when a person is not found by email, just return empty string instead of an error

Reduce code duplication when retrieving person info

TODO centralize caching

provide compatibility with AOLserver

make timeout cnd cache size configurable

follow usual naming conventions

    • -0
    • +23
Pass to a ns_cache implementation to avoid race conditions

Implement acs_user:: cache through nsv, instead of the util_memoize cache. Note that now this information won't expire anymore unless explicitly flushed.

Remove unnecessary backslashes, remove leftover usages of get_from_username_not_cached cache, minimize catch wrapping

Reuse acs_user::get_by_username to retrieve user_id in order to reduce query duplication and cache entries for acs_user::get, simplify idiom