• last updated 27 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
admin_p and user_p are actually never displayed, so it doesn't make sense to have them in the select clause. What makes sense is that we filter for those chats we can actually access

base_url is in fact just the package_url from the connection

base_url can be computed just once

Reduce divergency between oracle and postgres codebase and make the query less awkward

Don't overquote URL

Pass the creation user to the transcript object, as this proc is often called via scheduled procedure and won't find one otherwise

Provide a localized help-text for the xowiki-includelet feature (thanks to Günter Ernst for the german translation)

Improve formatting of messages

Fix upgrade

Add callback definition to the info file and define the contract properly as enforced by the UI

Maintenance upgrade to get rid of obsolete package parameters

file apm-callback-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/apm-callback-procs.tcl
Bump version numbers so chat depends on latest xotcl-core

  1. … 2 more files in changeset.
Rely on xotcl ORM machinery to handle acs_object metadata instead of doing it manually

Validation on 'get_instance_from_db' only

Move validation block into page contract

Right way to override the fetching of an object is thorugh the fetch query

This would not be necessary once we add acs_object attributes to ::xo::db::Object slots, but as side-effects of this are not clear we leave it for some other time

Fix upgrade script

Fix typo

Replace old procedural api with OO idioms and deprecate it

  1. … 12 more files in changeset.
file upgrade-6.0.0d1-6.0.0d2.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-6.0.0d1-6.0.0d2.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-6.0.0d1-6.0.0d2.sql
Chat Reform: reduce complexity by removing the 'chat_avatar_allow' privilege, 'chat_room_edit' should suffice.

    • -0
    • +12
    ./sql/oracle/upgrade/upgrade-6.0.0d1-6.0.0d2.sql
file xotcl-chat-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/xotcl-chat-procs.tcl
Major reform in the chat backend: use xotcl-core ORM to define all the relevant objects and data model

This greatly converges oracle and postgres codebase and will make easier to apply incremental updates to the data model in the future. It will also automatically update the acs_object_type metadata automatically

TODO: remove legacy procs, temporarly reimplemented using the new backend

    • -290
    • +1
    ./sql/postgresql/chat-create.sql
Remove old commented-out code

Update translations

  1. … 2 more files in changeset.
Chat data-model reform:

- introduce on delete cascade on foreign key constraints so package can be removed easily e.g. from the subsite UI

- remove remaining stored procedures (and function_args definitions) to relieve the burden on the development process and reduce divergency between oracle and postgres code

- converge oracle and postgres datamodels:

. oracle -> add missing messages_time_window column

. postgres -> remove creation_date from chat_transcripts, which was found to be still existing on old downstream installations

    • -0
    • +28
    ./sql/oracle/upgrade/upgrade-5.0.1d6-5.0.1d7.sql
    • -137
    • +8
    ./sql/postgresql/chat-create.sql
file upgrade-5.0.1d6-5.0.1d7.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.0.1d6-5.0.1d7.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.0.1d6-5.0.1d7.sql
Chat Redesign: add de_DE message keys for avatar display room attribute

Whitespace changes

    • -151
    • +149
    ./sql/oracle/chat-create.sql