• last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improve proc documentation

fix quoting issue

Reduce divergency between oracle and postgres codebase

  1. … 5 more files in changeset.
File storage max upload limit reform:

the max upload limit will now default to empty. Rationale: this value is

one that ages quickly with respect to new storage requirements, and is

currently set to something incompatible with the vanilla Naviserver configuration

(500MB fs vs 20MB ns).

The upgrade script will make so that instances setting this parameter

higher than the server upload limit configuration will be

set empty as well (this would never have an effect, as server

will prevent the upload altogheter anyway).

Max upload limit in bytes is now retrieved from a proc implementing

this fallback to server configuration logics. Other than centralizing,

its purpose is to be used in client-side code checks in the future

so we could prevent a doomed upload in advance.

  1. … 6 more files in changeset.
Fix typos

  1. … 8 more files in changeset.
Whitespace changes

  1. … 2 more files in changeset.
Fix parameter name in proc doc and add brief descriptions

  1. … 3 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 1 more file in changeset.
Fiy typo

Deprecated leftover parameter from year 2002

While working on reducing divergencies between oracle and postgres codebase and testing changes I have found the following issues:

- fs::add_created_version.new_text_revision query was defined in postgres only

- version-delete and folder-delete were broken in case notification was enabled,

because this was issued after object was deleted and therefore all references

needed to build notification message were missing (and query failed looking up the object)

  1. … 4 more files in changeset.
Whitespace changes

whitespace cleanup

mark required parameters as required. Fixes issue #3347

always use @see when procs are deprecated to show, what to use instead

improve spelling

  1. … 10 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
Fix typos

  1. … 7 more files in changeset.
Bugfix: content variable was not define before access (thanks to Giulia Nencini)

I am also not reading file content anymore, as this is potentially unsafe when file is very big and also could need special encoding translation etc.

Better retrieve the path and let the user decide what to do afterwards.

Revert db_exec_plsql or Oracle will break, remove leftover xql files

  1. … 2 more files in changeset.
Uniform API when deleting folder, drill through some calling levels in stored procedure, use a simpler db_string instead of db_exec_plsql

  1. … 2 more files in changeset.
Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 81 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Use site_node:: api to retrieve package_url instead of explicit query. Remove unused sql and simplify idiom for fs_get_folder_name.

  1. … 1 more file in changeset.
- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

  1. … 5 more files in changeset.
Remove sql duplication, converge oracle and postgres codebase

  1. … 3 more files in changeset.
Fix spelling errors

  1. … 12 more files in changeset.
Created new proc cr_check_mime_type, centralizing the retrieval of the mime_type from uploaded file's information.

Applied the new proc to the different situations in the system when we require mime_type retrieval: content-repository, file-storage and xotcl CrItem

TODO: get the real mime_type from the file content, but this would require some modification in the data model.

  1. … 7 more files in changeset.
.xql-file reform of file-storage

  1. … 18 more files in changeset.