• last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Localize file-size limits in the UI

Introduce a client-side check for the maximum file size, inform user of current limit and improve file-size related localization

Prettify code

Bugfixes et al:

- don't throw a server error if one clicks submit on the empty form without specifying a file

- allow to upload the same zipfile multiple times without throwing an error

- streamline idioms

File storage max upload limit reform:

the max upload limit will now default to empty. Rationale: this value is

one that ages quickly with respect to new storage requirements, and is

currently set to something incompatible with the vanilla Naviserver configuration

(500MB fs vs 20MB ns).

The upgrade script will make so that instances setting this parameter

higher than the server upload limit configuration will be

set empty as well (this would never have an effect, as server

will prevent the upload altogheter anyway).

Max upload limit in bytes is now retrieved from a proc implementing

this fallback to server configuration logics. Other than centralizing,

its purpose is to be used in client-side code checks in the future

so we could prevent a doomed upload in advance.

  1. … 6 more files in changeset.
Whitespace changes

  1. … 3 more files in changeset.
remove conditions, which are always true

remove parens

  1. … 2 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Improve robustness of "file delete" operations

  1. … 19 more files in changeset.
Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

  1. … 15 more files in changeset.
- use confirm handler instead of "onclick=..." in all packages in oacs-5-9

  1. … 15 more files in changeset.
- use event listener instead of onclick handler

- hint based on "fs_title_msg" is probably not shown since many years.

  1. … 1 more file in changeset.
- bump version number to 5.9.1d1

- improve security of page_contracts

  1. … 8 more files in changeset.
- handle case, where neither file_id nor folder_id is specified

.xql-file reform of file-storage

  1. … 18 more files in changeset.
- add editor hints to keep spaces/tabs in the future more consistent

  1. … 350 more files in changeset.
- standardize url construction to protect against injection attacks

- hardening page contracts

  1. … 8 more files in changeset.
- use type checking for boolean parameters in page_contracts to improve security

  1. … 14 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- fix for bug #3234

this adresses as well issue #731

  1. … 2 more files in changeset.
- simplify page_contract

- don't produce hard errors, when folder_id is not a valid number. The validator of the page_contract is called before the type of the query variables are checked. The db-query in the validator raised the hard sql error rather the intended error message

- use consistently "naturalnum" instead of "integer" when accepting just positive values

  1. … 103 more files in changeset.
- The C-library function tmpnam() is deprecated since a while. Therefore naviserver has deprecated ns_tmpnam as well.

Therefore we introduce a new function "ad_tmpnam" which requires just a minimal change and uses ns_mktemp.

  1. … 27 more files in changeset.
- fix bracing

- new style string expressions

- brace expressions to allow for tcl compilation

- use "in" or not in (ni) operator instead of lsearch

- bump version number

  1. … 23 more files in changeset.
- replace deprecated "export_url_vars" by "export_vars -url"

- fix bracing in "export_vars -form"

  1. … 121 more files in changeset.
- replace deprecated "ad_parameter" by "parameter::get"

  1. … 4 more files in changeset.
- the (deprecated) function ad_parameter was called with wrong arguments, "-package_id" was treated as parameter for non-positional argument "package_key" ("ad_parameter BehaveLikeFilesystemP -package_id [ad_conn package_id]"). Changed to "parameter::get"

Adding support for the categorization of files (if the CategoriesP parameter is enabled for a package instance). Version is increased to 5.4.0d3 and folder, file and simple www/*-edit-2 files were removed and consolidated into www/*-edit.

  1. … 33 more files in changeset.