• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
avoid localization substitutions in content of forums messages in notification messages

improve spelling

  1. … 8 more files in changeset.
Fix typo

Whitespace changes

  1. … 6 more files in changeset.
show forum-edit link only, if the current forum is from the current package (see admin/forum-edit)

Removed obsolete @arch-tag

    • -2
    • +1
    ./tcl/forums-callback-procs-oracle.xql
    • -2
    • +1
    ./tcl/forums-callback-procs-postgresql.xql
  1. … 28 more files in changeset.
Removed obsolete @arch-tag

  1. … 25 more files in changeset.
use consistently bind variables

port all former tclwebtest test cases to acs::test and do some more detailed testing

add tested API calls to testcases

modernize Tcl

- modularize web tests based on acs::test

- add new web tests for viewing and editing forums

    • -0
    • +143
    ./tcl/test/webtest-procs.tcl
move newly defined testing API (in OpenACS 5.10) to namespace acs::test

  1. … 8 more files in changeset.
Trim whitespaces

    • -129
    • +129
    ./tcl/test/tclwebtest-procs.tcl
- new API function: forum::delete (can't believe, this was missing)

- rework regression test

* make API calls explicit

* ported one test case from (broken) twt to aa_http

- bump version number to 1.3.1d6

    • -0
    • +11
    ./tcl/forums-procs-oracle.xql
    • -0
    • +11
    ./tcl/forums-procs-postgresql.xql
make tested API calls explicit

    • -130
    • +173
    ./tcl/test/forums-procs.tcl
improve rowcount expressions

  1. … 66 more files in changeset.
improve spelling

  1. … 11 more files in changeset.
Add documentation for public procs (fixes automated tests), replace faq with forum

Add documentation for public proc (fixes automated tests), feed user_id from arguments to permission api, explicitly default to current user (as called procs would do anyway)

Uniform documentation style, add documentation for public proc (fixes automated tests)

Deprecate (former) service contract implementations

Their body was always empty according to the cvs history and there is no mention of them in the code.

Their counterpart in the forum::notification namespace takes care of both forums and messages, therefore supersedes them.

    • -5
    • +15
    ./tcl/forum-message-reply-procs.tcl
Clearly separate callback hooks from callback implementations, uniform documentation style, remove duplicated callback implementation definitions, uniform indentation, add documentation to public procs (fixes automated tests)

    • -155
    • +111
    ./tcl/forums-callback-procs.tcl
Add documentation to public procs (fixes automated tests)

Uniform documentation style

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized for tests when a system was freshly restarted

Put cache flushing logics into procs and use them when forum info needs to be updated (fixes automated tests)

Add documentation and a fallback body for this deprecated proc

Provide a minimal documentation to public procs

Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 8 more files in changeset.