• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
whitespace changes

Whitespace changes

Localize notification subscribers and bump version number

    • -0
    • +2
    ./catalog/notifications.de_DE.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/notifications.en_US.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/notifications.es_ES.ISO-8859-1.xml
allow passing of pretty_names that contain content including less and greater sign

  1. … 1 more file in changeset.
Delete from duplicated notification request entries before trying to add the unique constraint to deal with broken data

improve comment

whitespace changes

Address issue #3358: avoid duplicate entries in notification_requests via data model, in case the check in notification::request::new for existing requests with the same type_id, object_id and user_id is somehow bypassed

    • -8
    • +10
    ./sql/oracle/notifications-core-create.sql
    • -0
    • +4
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
    • -0
    • +4
    ./sql/postgresql/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
Undeprecate and reimplement: require_admin_request, can_admin_request_p, require_notify_object and can_notify_object_p. Fixes in two templates (request-delete, request-change-frequency). (Many thanks to Felix Mödritscher for the patch!)

    • -16
    • +26
    ./tcl/notifications-security-procs.tcl
Fix parameter name in proc doc

Port a few downstream modifications to the main codebase

When changing notification frequency, show also name and creation date for the object

Driver is making easier to merge this script

Trim whitespace

Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 368 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 8 more files in changeset.
Prefer again 'person::name', as the proc has been reimplemented using 'person::get_person_info', which uses the new 'person_info_cache' cache.

  1. … 13 more files in changeset.
Deprecate 'notification::email::get_parameter', just a wrapper for 'parameter::get', used almost nowhere.

Whitespace changes

  1. … 11 more files in changeset.
Prefer 'acs_user::get_element ...' to 'person::name ...', in cases when 'person' is a user, as it doesn't rely on util_memoize_cache.

  1. … 13 more files in changeset.
Remove unnecessary join, as users are always persons and unnecessary stored procedure in order_by as we compute this in the column already

Remove divergency between oracle and postgres, bring all sql inline

    • -17
    • +0
    ./www/request-change-frequency-oracle.xql
    • -17
    • +0
    ./www/request-change-frequency-postgresql.xql
fix adp expressions

  1. … 2 more files in changeset.
Replace deprecated procs with 'permission::require_permission'

  1. … 1 more file in changeset.
Fix variable name

    • -2
    • +2
    ./tcl/notifications-security-procs.tcl
Deprecate wrappers for 'permission::permission_p' and permission::require_permission.

    • -5
    • +21
    ./tcl/notifications-security-procs.tcl
Implement the Notifications Security Library procs... 16 years after their creation.

    • -18
    • +31
    ./tcl/notifications-security-procs.tcl
add missing version dependencies for antonio's recent changes concering user info API

  1. … 5 more files in changeset.
Use api to avoid join

As username variable is not used, don't rely on side effects to check for user existance. Indentation changes.

Reuse person API instead of querying by hand

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 473 more files in changeset.