• last updated 40 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Replace single quotes wuith double quotes in javascript expressions involving acs_ListBulkActionClick

this is really needed only for the URL part, but was done on the name as well for consistency. The reason

is even a properly encoded URL could still contain single quotes, therefore breaking the expression,

while double quotes are expected to be encoded in valid, urlencoded URLs. This relies on trusting the developer

to properly encode URLs, which should be expected. An alternative could involve active escaping of

javascript special characters by e.g. ad_js_escape.

  1. … 6 more files in changeset.
backport from oacs-5-9, which might avoid problems with oacs 5-8 when used with recent versions of nsf

improve log messages

  1. … 1 more file in changeset.
provide ip address to be stored in acs_objects on save operation

Move chat machinery from xotcl-core to xowiki

Rationale: this feature makes little sense without the front-end xowiki provides and makes chat implementation harder to understand, as components are scattered in different packages.

  1. … 1 more file in changeset.
improve robustness of API browser when trying to browse non-existing objects

  1. … 1 more file in changeset.
improve robustness of API browser when trying to browse non-existing objects

improve robustness of API browser when trying to browse non-existing objects

Improve error handling idioms and handle additional error cases where the client has just disconnected

Try to trap additional disconnection-related errors

Put the puts operation in the try catch as well

reduce number of hits in prepared statement nsv cache by using a per-interp cache

Chat Redesign:

+ New style classes, opening the door to further graphic redesign.

+ Revamping of the user list.

+ Revamping of the input block.

+ Small changes in the messages block, including floating timestamps to the right.

+ Responsive design: use flexbox for chat layout.

+ Responsive design: make user list horizontally scrollable for 'small' widths.

+ Expose user_id in a hidden div, in the chat adp, so it can be used by the javascript part to check and assign different styles to the chat messages if they belong to the user watching the page.

+ xotcl-core: Pass color and user_id in the message, avoiding the creation of the user link at this level.

+ xotcl-core: Remove user_link proc.

+ xowiki: Avoid autocompletion in input field.

+ xowiki: Adding and relocation of div elements.

+ xowiki: Simple function to transform url-like elements of the messages into links.

+ xowiki: Create user links in chat-common.js.

+ xowiki: Check user_id and assign classes to elements depending on the user watching the page.

  1. … 4 more files in changeset.
Fix typo in comment

Use finer grained error handling to intercept disconnection from client

Treat failure to flush the channel as just a warning, because this usually just means client (e.g. browser in a chat) closed the connection

PostgreSQL compatibility fix: Newer versions of PostgreSQL return default values with

type casts (e.g. 'en_US'::character varying). These have to be removed before

comparing with plain values.

reduce verbosity

remove comma before that

  1. … 6 more files in changeset.
minor refactoring: factor out limit_clause

improve comments

use NaviServer/AOLserver native mutex and prefer the more secure ad_mutex_eval

bump version number of jquery to 1.12.3

  1. … 1 more file in changeset.
Quote the backslash as well...

improve spelling

Chat reform:

- rework xotcl-core chat machinery to return its responses through JSON and include information about active users

- depend on xowiki instead of xotcl-core only

- exploit xowiki "Comet" server push implementation when the browser supports it

- reduce code duplication

- drop plain HTML chat

- reduce hardcoded styling

- minor cleanups

  1. … 23 more files in changeset.
improve spelling

  1. … 8 more files in changeset.
Converge render method for chat and xotcl-core package

  1. … 1 more file in changeset.
Fix quoting of single quotes in JSON

Avoid javascript eval idiom as CSP will refuse to execute when unsafe-eval is disabled

This requires moving to a more approprate JSON parser... which is also pickier regarding single quotes, so I had to rework JSON encoding to please it.

  1. … 1 more file in changeset.