• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
prefer package object over plain id

  1. … 1 more file in changeset.
prefer package object over plain id

removed commented out code

- modernize code (remove "my")

- prefer fully qualified commands based on IDs

  1. … 33 more files in changeset.
improve spelling

  1. … 10 more files in changeset.
call validator method on "Properties"

make sure to quote error message properly

improve spelling

  1. … 13 more files in changeset.
Allow Workflow Conditions to be evaluated in form fields via evaluate_form_field_condition

  1. … 1 more file in changeset.
make test cases proper test cases using the automated testing framework

  1. … 1 more file in changeset.
improve startuptime for large sites

  1. … 2 more files in changeset.
provide documentation of public procs and methods, make some procs private

  1. … 3 more files in changeset.
provide language for rendering of the workflow definition

improve comments a little

Deprecate get_root_dir proc, duplicated to every extent by acs_root_dir

  1. … 9 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 225 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
improve code documentation

  1. … 10 more files in changeset.
prefer XOTcl2 idioms

  1. … 2 more files in changeset.
prefer XOTcl2 idioms

  1. … 4 more files in changeset.
remove obsolete comment (basic hastore support was moved to xowiki)

make sure to create in initialize WorkflowContext new and remove duplicated instproc

use directly revision of workflow in id of wf_container when object is a workflow

fallback to determine the workflow context from the workflow page, needed for call_action

fix variable name

reduce verbosity

Cleanup of yesterdays changes (based on experiences with learn@wu)

Whitespace changes

  1. … 1 more file in changeset.
Shared Workflow Definitions (Part 2)

When shared workflow definition are used, a different management of

object specific code is necessary, since one definition seves for many

objects, and it is not freshly created per object. Therefore, a new

concept is introduced for workflow definitions, named "object-specifc"

Instead of writing in a workflow definition

Action save

state initial -actions {save}

[my object] proc foo {} { ns_log notice "===foo==="}

one has to write now:

Action save

state initial -actions {save}

:object-specific {

:proc foo {} { ns_log notice "===foo==="}

}

where the object-specific is evaluated once per request for every

involved workflow instance in the context of the object (a [self]

in this block refers to the object).

In case a [my object] is encountered and sharedWorkflowDefinition is

activated, a warning is produced and the code falls back to old-style

shared workflow definitions.

  1. … 3 more files in changeset.
Turn off shared workflow definition as indicated in the last message