• last updated 47 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove leftover alert

Avoid javascript eval idiom as CSP will refuse to execute when unsafe-eval is disabled

This requires moving to a more approprate JSON parser... which is also pickier regarding single quotes, so I had to rework JSON encoding to please it.

Make ad_sanitize_html not hardly dependant on a connection being there (thanks to Markus moser for the report)

Also, update documentation and make idioms less awkward.

(this passes automated tests)

    • -33
    • +45
    ./acs-tcl/tcl/text-html-procs.tcl
Add editor hints + Whitespace changes

Make util_current_location robust such it does not raise an exception when not connected. In these cases, the configured ad_url is returned. This is not perfect either, since it would not work with host-node mapped subsites, and maybe, there are cases, where one wants just information based on the actual connection. so, maybe, one should provide either a higher level API and/or parameterize util_current_location in the future.

extend list of embedded content types

    • -3
    • +3
    ./xotcl-request-monitor/tcl/throttle_mod-procs.tcl
improve comments

    • -3
    • +3
    ./acs-tcl/tcl/request-processor-procs.tcl
    • -3
    • +4
    ./acs-tcl/tcl/site-node-apm-integration-procs.tcl
    • -11
    • +11
    ./acs-tcl/tcl/utilities-procs.tcl
    • -5
    • +5
    ./acs-admin/www/test/signed-cookies-test.tcl
    • -2
    • +2
    ./acs-api-browser/www/package-view.tcl
improve capitalization and wording in comments

    • -11
    • +11
    ./acs-templating/tcl/head-procs.tcl
    • -13
    • +16
    ./acs-templating/tcl/list-procs.tcl
    • -4
    • +4
    ./acs-templating/www/doc/demo/list6/index.tcl
    • -2
    • +2
    ./acs-templating/www/scripts/xinha/attach-file.tcl
Fix typo

Whitespace changes

    • -10
    • +6
    ./assessment/tcl/as-action-proc.tcl
    • -16
    • +14
    ./assessment/www/admin/asm-action-new.tcl
    • -62
    • +17
    ./assessment/www/admin/set-reg-assessment.tcl
Fix typos

    • -2
    • +2
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
Whitespace changes

    • -1
    • +1
    ./acs-lang/www/admin/message-conflict-revert.tcl
    • -50
    • +49
    ./categories/tcl/category-trees-procs.tcl
Fix typos

    • -2
    • +2
    ./acs-content-repository/tcl/content-item-procs.tcl
    • -1
    • +1
    ./acs-lang/www/admin/message-conflict-revert.tcl
    • -3
    • +3
    ./categories/tcl/category-trees-procs.tcl
dotlrn cache reform: move caching from util_memoize into three seperate caches to reduce stress on util_memoize.

These caches are:

- ::dotlrn::dotlrn_cache

Default general purpose cache for dotlrn-wide value (e.g. available applets, etc)

- ::dotlrn::dotlrn_user_cache

Partitioned cache for values specific to a user (e.g. personal_portal_id, theme_id, etc)

- ::dotlrn::dotlrn_community_cache

Partitioned cache for values specific to a community (e.g name, roles, portal_id, etc)

    • -63
    • +100
    ./dotlrn/tcl/community-procs.tcl
    • -2
    • +2
    ./dotlrn/tcl/dotlrn-security-procs.tcl
    • -2
    • +2
    ./dotlrn/www/admin/add-edit-site-template.tcl
Trailing space cleanup

    • -23
    • +23
    ./acs-tcl/tcl/whos-online-procs.tcl
Whitespace changes

    • -206
    • +206
    ./acs-tcl/tcl/widgets-procs.tcl
Fix typos in proc doc

Better separate data from formatting

Provide tests for public procs: min and max

    • -0
    • +25
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Normalize indentation

Decouple a bit formatting from data

    • -0
    • +48
    ./chat/www/ajax/chat.adp
Give templating a chance

move all hardcoded styling to the adp template, which might be styled by the theme. Also, biring some order in the login proc, e.g. don't open and read a file to include a javascript all the time.

Provide tests for public procs: util_escape_quotes_for_csv

    • -0
    • +17
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Provide tests for public procs: util_commify_number

    • -1
    • +30
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Whitespace changes

    • -134
    • +134
    ./faq-portlet/tcl/test/faq-portlet-procs.tcl
    • -177
    • +176
    ./faq-portlet/tcl/test/tclwebtest-procs.tcl
Fix typos

    • -2
    • +2
    ./faq-portlet/tcl/test/faq-portlet-procs.tcl
    • -9
    • +9
    ./faq-portlet/tcl/test/tclwebtest-procs.tcl
Modernize XoTcl idioms

Refactor test case for util_absolute_path_p

    • -6
    • +14
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Provide tests for public procs: util_complete_url_p

    • -0
    • +25
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Fix doc typo